Skip to content

fix(discover): retain external source directories in fast mode (#2151) - #2161

Open
htarnacki wants to merge 1 commit into
DeusData:mainfrom
htarnacki:fix/discover-external-fast-mode
Open

fix(discover): retain external source directories in fast mode (#2151)#2161
htarnacki wants to merge 1 commit into
DeusData:mainfrom
htarnacki:fix/discover-external-fast-mode

Conversation

@htarnacki

@htarnacki htarnacki commented Sep 10, 2026

Copy link
Copy Markdown

What does this PR do?

Fixes #2151.

external was listed in FAST_SKIP_DIRS, so fast and moderate discovery silently dropped every directory with that name — in many codebases first-party code (external-facing APIs, adapters, integration layers). The vendored case remains covered by vendor, vendored, third_party, thirdparty, 3rdparty. This removes the single external entry and adds no_skip_fast_external to test_discover.c.

Diff note: clang-format-20 reflows the shortened initializer to one item per line, so the list is regrouped with category comments in the same style as ALWAYS_SKIP_DIRS; order and the other entries are unchanged.

Related: #1406, #1184 (same silent-exclusion family; not addressed here).

Checklist

  • Every commit is signed off (git commit -s) — required, CI rejects
    unsigned commits (DCO, see CONTRIBUTING.md)
  • Tests pass locally (make -f Makefile.cbm test) — all suites green except 10 test_cli.c install/uninstall cases that fail identically on a clean main in my environment (activation transaction I/O failed: target-entry-snapshot, environment-specific).
  • Lint passes (make -f Makefile.cbm lint-ci) — clang-format-20 and check-dco.sh clean; clang-tidy / cppcheck are not installed locally, relying on CI for those two.
  • New behavior is covered by a test (reproduce-first for bug fixes)

@htarnacki
htarnacki requested a review from DeusData as a code owner September 10, 2026 08:41
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

Thanks for opening this — it has been seen, and it is queued.

This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence.

Current review status: working through a backlog. 0.9.1-rc.1 is out, so the release freeze that held reviews is over — but it left a large queue of open pull requests behind it, and we are reading through them oldest-first. The background is in discussion #1144.

What that means for this PR, concretely:

  • It will not be closed for inactivity. No stale bot touches pull requests here.
  • It may still sit a while before a human reads it. That is on us, not on you.
  • Older PRs are read first, so a recent one is not being skipped — it is behind a queue.

Things that will genuinely speed it up whenever review does happen:

  • Keep it rebased on main — the tree is moving quickly right now, and a conflicting branch cannot be reviewed as the diff you intended.
  • Get CI green, or say which failures you believe are pre-existing.
  • Keep the change to one claim. Bundled features and refactors get split before they get merged, which costs you a round trip.
  • Every commit needs a sign-off (git commit -s) — CI enforces DCO.

If this fixes a bug, a reproduction we can run is worth more than a description of the symptom.

Thanks for contributing, and sorry in advance for the wait.

@htarnacki
htarnacki force-pushed the fix/discover-external-fast-mode branch from c8e244d to 6790e1a Compare September 10, 2026 10:12
@htarnacki
fix(discover): retain external source directories in fast mode
80f8bda 
`external` was listed in FAST_SKIP_DIRS, so fast and moderate discovery
silently dropped every directory named `external`. In many codebases
that name holds first-party code (external-facing APIs, adapters,
integration layers) rather than vendored third-party sources, and the
dedicated `vendor` / `third_party` / `3rdparty` entries already cover
the vendored case. Remove `external` from the fast skip list so those
sources are indexed in every mode.

The shortened list is regrouped with category comments in the same
style as ALWAYS_SKIP_DIRS; element order is unchanged.

Signed-off-by: Hubert Tarnacki <hubert.tarnacki@gmail.com>
@htarnacki
htarnacki force-pushed the fix/discover-external-fast-mode branch from 6790e1a to 80f8bda Compare September 14, 2026 08:38
@DeusData DeusData added bug Something isn't working parsing/quality Graph extraction bugs, false positives, missing edges priority/high Needs near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker. labels Sep 19, 2026
@DeusData

DeusData commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Thank you for the discovery fix and focused mapping regression. Current non-full discovery still applies the built-in external exclusion, so the test targets an identifiable discovery path. Review will need to retain the distinction between this directory heuristic and the remaining ignore rules; this is not approval to relax every exclusion.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeusData DeusData Awaiting requested review from DeusData DeusData is a code owner

Assignees

No one assigned

Labels

bug Something isn't working parsing/quality Graph extraction bugs, false positives, missing edges priority/high Needs near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fast/moderate discovery silently skips every directory named external (FAST_SKIP_DIRS)

2 participants

@htarnacki @DeusData